Re: [PATCH v3] EDAC/altera: use ECC manager compatible to select A10/S10 IRQ layout

[Dinh Nguyen]

On 6/16/26 09:07, Rounak Das wrote:
> The SDMMC ECC IRQ layout selection uses CONFIG_64BIT to distinguish
> between Arria10 and Stratix10 paths. This is architecture-based,
> while the interrupt layout is a hardware property described by DT
> compatible strings.
>
> Detect the SoC once at probe via the altr,socfpga-s10-ecc-manager
> compatible on the ECC manager node, store it under the struct
> altr_arria10_edac, and use it in altr_portb_setup() and
> altr_edac_a10_device_add() in place of CONFIG_64BIT.
>
> Selecting on the manager compatible keeps the decision SoC-wide and
> correct for every ECC child device (OCRAM, USB, EMAC, SD/MMC),
> and avoids repeated compatible lookups. Stratix10 and
> Agilex both declare altr,socfpga-s10-ecc-manager and Arria10 does not,
> so behaviour is unchanged on all three SoCs.
>
> Signed-off-by: Rounak Das <rounakdas2025@xxxxxxxxx>
> ---
> v3:
>   - Use compatible string altr,socfpga-s10-ecc-manager instead of
>     sdmmc-ecc (Dinh).
>   - Set it once into struct altr_arria10_edac::is_s10 to
>     avoid repeated of_device_is_compatible() calls (Dinh).
>   - Fix the checkpatch open-parenthesis alignment.
>
> v2: https://lore.kernel.org/linux-edac/20260616081709.48774-1-rounakdas2025@xxxxxxxxx/
>   - Use legal name in Signed-off-by (Borislav).
>
>   drivers/edac/altera_edac.c | 106 +++++++++++++++++++------------------
>   drivers/edac/altera_edac.h |   1 +
>   2 files changed, 55 insertions(+), 52 deletions(-)

Were you able to test this on any HW? I tested on an Arria10 and it 
looks good. Currently, I don't have access to a 64-bit platform. so I'd 
like to wait to get access to one and test.

Thanks,
Dinh