Re: [PATCH] arm64: dts: qcom: sc8280xp: add missing QUP pinctrl states

[Konrad Dybcio]

On 5/7/26 4:44 PM, Xilin Wu wrote:
> Add the missing tlmm pinctrl states for the SC8280XP QUP engines so common
> I2C, SPI and UART pinmux definitions are available from the SoC dtsi.
> Populate all 24 engines using the SC8280XP lane-to-GPIO mapping, including
> the non-linear QUP instances, and keep the mux function names aligned with
> the driver-supported qup0..qup23 names.
> 
> Move UART electrical settings out of the shared SoC pinctrl states and
> into the board dts files that need them. Update the boards that currently
> duplicate uart2 pinctrl definitions to reference qup_uart2_default and
> override only the required bias and drive properties locally, and do the
> same for Arcata's uart18 configuration. This reduces duplicated pinctrl
> data and keeps the shared SC8280XP states reusable for future QUP users.
> 
> Signed-off-by: Xilin Wu <sophon@xxxxxxxxx>
> ---

[...]

> +			qup_uart0_default: qup-uart0-default-state {
> +				qup_uart0_cts: cts-pins {
> +					pins = "gpio135";
> +					function = "qup0";
> +				};
> +				qup_uart0_rts: rts-pins {
> +					pins = "gpio136";
> +					function = "qup0";
> +				};
> +				qup_uart0_tx: tx-pins {
> +					pins = "gpio137";
> +					function = "qup0";
> +				};
> +				qup_uart0_rx: rx-pins {
> +					pins = "gpio138";
> +					function = "qup0";
> +				};
> +			};

I find this overly verbose. Let's go for something like in glymur.dtsi,
where the common defaults are defined. I think we can even keep the
bluetooth/4way-uart configuration default as 99.999% boards will use
that

Konrad