Re: [PATCH 4/4] regulator: tps6594: Fix device node reference leaks in multiphase loop
From: Mark Brown
Date: Thu Jun 18 2026 - 09:37:23 EST
On Thu, Jun 18, 2026 at 06:53:27PM +0530, Uday Khare wrote:
> In tps6594_regulator_probe(), the multi-phase configuration loop calls
> of_find_node_by_name() to find buck nodes by name, and of_get_parent()
> twice to navigate to the PMIC parent node. None of the acquired node
> references (np, intermediate parent, np_pmic_parent) are ever released
> via of_node_put(), causing a reference leak on every loop iteration.
You've not copied me on the rest of the series so I don't know what's
going on with dependencies. When sending a patch series it is important
to ensure that all the various maintainers understand what the
relationship between the patches as the expecation is that there will be
interdependencies. Either copy everyone on the whole series or at least
copy them on the cover letter and explain what's going on. If there are
no strong interdependencies then it's generally simplest to just send
the patches separately to avoid any possible confusion.
Attachment:
signature.asc
Description: PGP signature