Re: [PATCH v2 1/1] ALSA: usb: Add support for Reloop Jockey 3 DJ controllers

[Frank van de Pol]

On Thu, Jun 18, 2026 at 11:53:33AM +0100, Julian Braha wrote:
> Hi Frank,
> 
> On 6/17/26 21:39, Frank van de Pol wrote:
> 
> > +source "sound/usb/jockey3/Kconfig"
> >  
> >  endif	# SND_USB
> >  
> > diff --git a/sound/usb/Makefile b/sound/usb/Makefile
> > index e62794a87e73..1f045c00dbc9 100644
> > --- a/sound/usb/Makefile
> > +++ b/sound/usb/Makefile
> > @@ -37,3 +37,4 @@ obj-$(CONFIG_SND_USB_US122L) += snd-usbmidi-lib.o
> >  
> >  obj-$(CONFIG_SND) += misc/ usx2y/ caiaq/ 6fire/ hiface/ bcd2000/ qcom/
> >  obj-$(CONFIG_SND_USB_LINE6)	+= line6/
> > +obj-$(CONFIG_SND_USB_JOCKEY3) += jockey3/
> > diff --git a/sound/usb/jockey3/Kconfig b/sound/usb/jockey3/Kconfig
> > new file mode 100644
> > index 000000000000..a1ac80f04450
> > --- /dev/null
> > +++ b/sound/usb/jockey3/Kconfig
> > @@ -0,0 +1,19 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +config SND_USB_JOCKEY3
> > +	tristate "Reloop Jockey 3 support"
> > +	default m
> > +	depends on SND_USB && USB
> > +	select SND_PCM
> > +	select SND_RAWMIDI
> 
> The dependency on SND_USB is unnecessary here, since the:
> 'source "sound/usb/jockey3/Kconfig"'
> is already inside of an 'if SND_USB' so every config option in that file
> depends on SND_USB.
> 
> - Julian Braha

Thank you Julian, good point. I'll update this when I'll prepare v3 of my patch for this driver.

I saw that the Sashiko review / code analysis found some more issues I
introduced with my latest changes, including a potential AB-BA deadlock
which I want to address.

https://sashiko.dev/#/patchset/20260617203937.1273852-2-fvdpol%40gmail.com


@Takashi, please do not yet merge this patch. I'd like to do more analysis
on the Sashiko feedback and further improve the code quality for this
driver.


Any further feedback and suggestions for improvement are more than welcome,
best regards,
Frank.