Re: [PATCH v1 2/3] mm/damon: introduce DAMON_HUGEPAGE for hot region hugepage collapsing

[SeongJae Park]

On Thu, 18 Jun 2026 14:51:42 +0300 Gutierrez Asier <gutierrez.asier@xxxxxxxxxxxxxxxxxxx> wrote:

> Hi SJ,
> 
> On 6/18/2026 3:16 AM, SeongJae Park wrote:
> > On Tue, 16 Jun 2026 21:04:52 -0700 SeongJae Park <sj@xxxxxxxxxx> wrote:
> > 
> >> On Tue, 16 Jun 2026 15:03:15 +0000 <gutierrez.asier@xxxxxxxxxxxxxxxxxxx> wrote:
> >>
> >>> From: Asier Gutierrez <gutierrez.asier@xxxxxxxxxxxxxxxxxxx>
> >>>
> >>> This patch introduces a new DAMON module (SAMPLE_DAMON_HPAGE)
> >>> which collapses hot regions into huge pages.
> > 
> > As I mentioned on the previous version of this series, this sample module looks
> > much better than the initial shape to my humble eyes.  Much smaller and
> > simpler.  I really appreciate Asier's efforts on making this.
> > 
> > However... I was asking myself if this module is really needed last night, and
> > still got not real good and confident answer.
> > 
> > After all, this is a sample module.  The purpose is to show sample code thhat
> > helps people understanding how they can use DAMON API.  Maybe we can argue this
> > module can be helpful at understanding how DAMOS quota goal can be used.  But,
> > mtier is already showing that.  So I cannot say what new advantage this module
> > is really bringing.
> You are right, the main goal was to show how this quota goal can be used. 
> > Meanwhile, this patch adds ~200 lines of code.  It is a very small and simple
> > sample module, but still we should maintain it.  I, to be honest, getting
> > little bit concerned about the maintenance overhead now.
> I understand your concerns. I know code need maintenance, and DAMON is already
> growing significantly.
> > So, if Asier has a good reason to add this module that I'm missing, I'd like to
> > humbly ask to consider dropping of this module for now.  I'm so sorry for
> > raising this concern this late.  But, Asier, may I ask what do you think?
> So, are you suggesting to drop the module and upstreaming only the DAMOS quota
> goal stuff?> 

Yes, if you don't mind.


Thanks,
SJ

[...]