Re: [PATCH v2 14/17] afs: Remove erroneous seq |= 1 in volume lookup loop

From: Oleg Nesterov

Date: Thu Jun 18 2026 - 11:12:25 EST


On 06/18, David Howells wrote:
>
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> > > --- a/fs/afs/internal.h
> > > +++ b/fs/afs/internal.h
> > > @@ -750,8 +750,6 @@ static inline void afs_vnode_set_cache(struct afs_vnode *vnode,
> > > {
> > > #ifdef CONFIG_AFS_FSCACHE
> > > vnode->netfs.cache = cookie;
> > > - if (cookie)
> > > - mapping_set_release_always(vnode->netfs.inode.i_mapping);
> > > #endif
> >
> > This change looks unrelated...
>
> If I remove that bit, can I add your R-b?

Yes, thank you!

Oleg.