Re: [PATCH 1/2] media: i2c: ov08d10: unconditionally use the startup delay

[Kieran Bingham]

Quoting Matthias Fend (2026-06-18 10:31:12)
> Even though the datasheet does not describe the timings for operation
> without a dedicated hardware reset, it seems sensible to wait for the
> "XSHUTDN pull up to SCCB start" time even if no reset line is available.
> 
> Signed-off-by: Matthias Fend <matthias.fend@xxxxxxxxx>
> ---
>  drivers/media/i2c/ov08d10.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/ov08d10.c
> index 9adef5446a61f3204fb809ca3f077c1afb5f7a47..cb7e55b168781dfeaae553734d24208a374fce9c 100644
> --- a/drivers/media/i2c/ov08d10.c
> +++ b/drivers/media/i2c/ov08d10.c
> @@ -1358,11 +1358,11 @@ static int ov08d10_power_on(struct device *dev)
>                 fsleep(5 * USEC_PER_MSEC);
>  
>                 reset_control_deassert(ov08d10->reset);
> -
> -               /* Delay from XSHUTDN pull up to SCCB start: 8ms */
> -               fsleep(8 * USEC_PER_MSEC);
>         }
>  
> +       /* Delay from XSHUTDN pull up to SCCB start: 8ms */

8 ms seems like a long delay at startup... but it was preceeding this
patch anyway.

If there's no hardware reset line, then I'd expect the module to have
tied that in - so I expect the delay is still required too.

Reviewed-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>


> +       fsleep(8 * USEC_PER_MSEC);
> +
>         return 0;
>  }
>  
> 
> -- 
> 2.34.1
>