Re: [PATCH v2 1/2] iio: chemical: sps30: update email
From: Andy Shevchenko
Date: Thu Jun 18 2026 - 13:53:46 EST
On Thu, Jun 18, 2026 at 06:21:39PM +0200, Tomasz Duszynski wrote:
> > On Wed, Jun 17, 2026 at 07:27:15PM +0200, Tomasz Duszynski wrote:
...
> > > .mailmap | 1 +
> > > drivers/iio/chemical/sps30_i2c.c | 4 ++--
> > > drivers/iio/chemical/sps30_serial.c | 4 ++--
> >
> > I don't care much, but the cleaner approach is to have a separate patch
> > for .mailmap and put it at the end of the series. Otherwise it's confusing
> > that it's related to a certain driver, while changes are applied across
> > the whole tree.
>
> No strong opinions on the change itself, maybe except patch ordering.
> I'd rather see mail mapping update placed before driver changes to make
> sure it is visible if bisect ends up in the middle of the series.
Works for me as well. Just make it separate.
--
With Best Regards,
Andy Shevchenko