Re: [PATCH 1/2] dt-bindings: thermal: Add Qualcomm MBG thermal monitor support

[Sachin Gupta]

On 6/8/2026 3:37 PM, Krzysztof Kozlowski wrote:
> On Mon, Jun 01, 2026 at 04:31:18PM +0530, Sachin Gupta wrote:
> > From: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> >
> > Add bindings for the Qualcomm MBG (Master Bandgap) temperature alarm peripheral
>
> Feels unwrapped.
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

I will re-wrap the commit message in the next revision.

> > found on the PM8775 PMIC. Unlike the existing SPMI temp alarm peripheral,
> > the MBG peripheral supports both hot and cold threshold monitoring across
> > two programmable levels (LVL1 and LVL2), with interrupt status reported via
> > a fault status register over SPMI.
> >
> > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> > Co-developed-by: Sachin Gupta <sachin.gupta@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Sachin Gupta <sachin.gupta@xxxxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml    |  4 ++
> >   .../bindings/thermal/qcom-spmi-mbg-tm.yaml         | 72 ++++++++++++++++++++++
> >   2 files changed, 76 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > index 644c42b5e2e5..5f409fe700b2 100644
> > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> > @@ -193,6 +193,10 @@ patternProperties:
> >       type: object
> >       $ref: /schemas/thermal/qcom,spmi-temp-alarm.yaml#
> >   
> > +  "^temperature-sensor@[0-9a-f]+$":
> > +    type: object
> > +    $ref: /schemas/thermal/qcom-spmi-mbg-tm.yaml#
> > +
> >     "^typec@[0-9a-f]+$":
> >       type: object
> >       $ref: /schemas/usb/qcom,pmic-typec.yaml#
> > diff --git a/Documentation/devicetree/bindings/thermal/qcom-spmi-mbg-tm.yaml b/Documentation/devicetree/bindings/thermal/qcom-spmi-mbg-tm.yaml
> > new file mode 100644
> > index 000000000000..a0ecc9f35cf6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/qcom-spmi-mbg-tm.yaml
>
> Filename must match compatible.

Thanks for the review. I can rename this to match the compatible naming, 
but wanted your preference on scope:

Should I use a generic naming scheme (qcom,spmi-mbg-tm.yaml with 
matching compatible), or make it PMIC-specific (qcom,pm8775-mbg-tm.yaml).

Thanks,
Sachin

> > @@ -0,0 +1,72 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/thermal/qcom-spmi-mbg-tm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm's SPMI PMIC MBG Thermal Monitoring
>
> Best regards,
> Krzysztof