Re: [PATCH] mfd: rohm: Factor out power button registration

[Lee Jones]

On Thu, 18 Jun 2026, Dmitry Torokhov wrote:

> Factor out the power button registration logic using software nodes
> from rohm-bd718x7 and rohm-bd71828 drivers into a shared module
> rohm-pwrbutton.
> 
> This reduces duplication and makes it easier to support other ROHM
> PMICs with similar power button configurations.
> 
> Suggested-by: Lee Jones <lee@xxxxxxxxxx>
> Assisted-by: Antigravity:gemini-3.5-flash
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Quick drive-by nit: Drop the term 'mfd' from function names please.

> ---
>  MAINTAINERS                  |   2 +
>  drivers/mfd/Kconfig          |   6 ++
>  drivers/mfd/Makefile         |   1 +
>  drivers/mfd/rohm-bd71828.c   |  84 ++------------------------
>  drivers/mfd/rohm-bd718x7.c   |  84 ++------------------------
>  drivers/mfd/rohm-pwrbutton.c | 112 +++++++++++++++++++++++++++++++++++
>  drivers/mfd/rohm-pwrbutton.h |  12 ++++
>  7 files changed, 141 insertions(+), 160 deletions(-)

-- 
Lee Jones