Re: [GIT PULL] tracing: Updates for 7.2
From: Steven Rostedt
Date: Fri Jun 19 2026 - 08:17:05 EST
On Thu, 18 Jun 2026 21:23:04 -0700
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> The intent was clearly to make people who actually needed the
> trace_printk() functionality to include the header - that's what the
> commit log says. But that's not how any of it works ;(
>
> So all that commit did was to make things look like they wouldn't hurt
> as much as they do, and that trivial change to that file causes a full
> rebuild of the kernel.
>
> I'm not seeing any patches even being discussed that would make only
> files that need it to include that file and remove it from
> linux/kernel.h that *everybody* uses. Yet that was the *only* point of
> making it a separate header in the first place. Yury?
Many developers use trace_printk() over printk(). Requiring people to
add that include for every use case would severely limit debugging of
the kernel. Would you be OK if we did the same for printk? That is, if
you want to add a printk to a function, you had to add a include
printk.h to the file before doing so?
-- Steve