Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp: Add camera MCLK pinctrl

[Vladimir Zapolskiy]

On 6/19/26 16:03, Konrad Dybcio wrote:
> On 6/19/26 2:59 PM, Vladimir Zapolskiy wrote:
> > On 6/19/26 15:35, Konrad Dybcio wrote:
> > > On 6/11/26 7:29 AM, Pengyu Luo wrote:
> > > > On Tue, Jun 9, 2026 at 8:17 PM Konrad Dybcio
> > > > <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
> > > > > On 6/7/26 6:04 PM, Pengyu Luo wrote:
> > > > > > Define pinctrl definitions to enable camera master clocks on sc8280xp.
> > > > > >
> > > > > > Suggested-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
> > > > > > Signed-off-by: Pengyu Luo <mitltlatltl@xxxxxxxxx>
> > > > > > ---
> > > > > >    arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 56 ++++++++++++++++++++++++++
> > > > > >    1 file changed, 56 insertions(+)
> > > > > >
> > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > > > > > index a2bd6b10e475..0dbcd3069a3b 100644
> > > > > > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > > > > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> > > > > > @@ -5484,6 +5484,62 @@ tlmm: pinctrl@f100000 {
> > > > > >                         gpio-ranges = <&tlmm 0 0 230>;
> > > > > >                         wakeup-parent = <&pdc>;
> > > > > >
> > > > > > +                     cam_mclk0_default: cam-mclk0-default-state {
> > > > > > +                             pins = "gpio119";
> > > > > > +                             function = "cam_mclk";
> > > > > > +                             drive-strength = <6>;
> > > > >
> > > > > Other platforms set this to 2 by default.
> > > > >
> > > > > What's the value set on Windows when the camera is in use?
> > > >
> > > > It is 6mA.
> > > >
> > > > Let us get ctl_reg first on Windows
> > > >
> > > > lkd> !dd f111000 L8
> > > > # f111000 00000284 00000002 000000e2 00000000
> > > > # f111010 00000001 00000801 00000000 00000000
> > > >
> > > > ctl_reg => 0x284
> > > >
> > > > in msm_gpio_dbg_show_one()
> > > > ...
> > > > drive = (ctl_reg >> g->drv_bit) & 7; // (0x284 >> 6) & 7 == 2
> > > > ...
> > > > seq_printf(s, " %dmA", msm_regval_to_drive(drive)); // (drive + 1) * 2 == 6;
> > > > ...
> > > >
> > > > x13s should be the same as gaokun3 in this part.
> > >
> > > I confirmed as much and I'm willing to believe this is a default for
> > > all 8280 devices
> > >
> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > >
> > > for the second patch, please mention in the commit message that the value
> > > will now match windows and please add a fixes tag
> >
> > I believe the second change cannot be tagged as Fixes in sense that it
> > strictly depends on a not going to be backported non-fix commit, and thus
> > backporting of just 2/2 change as is will break the matter. Reordering of
> > the commits placing the fix commit as the first one should be fine though.
>
> The Fixes tag makes the patch eligible for backporting through AUTOSEL
> but is itself not the same as "please backport"

That's correct, and due Documentation/process/stable-kernel-rules.rst it
would make sense to add Cc: <stable+noautosel@xxxxxxxxxx> to the next
version of the change to help stable tree maintainers, since it is known
in advance that the unmodified and Fixes tagged 2/2 change shall not be
considered as a candidate change to the stable tree. Or is it excessive?

IMHO here it might be better to properly arrange the changes and backport
the fix.

--
Best wishes,
Vladimir