Re: [PATCH 2/3] spi: bcm63xx-hsspi: return error from failed controller suspend

[William Zhang]

On Thu, Jun 18, 2026 at 9:45 AM Jiawen Liu <1298662399@xxxxxx> wrote:
>
> spi_controller_suspend() can fail if the SPI core cannot stop the
> controller. bcm63xx_hsspi_suspend() ignored that error, disabled the
> PLL and core clocks, and returned success.
>
> Return the suspend error before disabling the clocks.
>
> Signed-off-by: Jiawen Liu <1298662399@xxxxxx>
> ---
>  drivers/spi/spi-bcm63xx-hsspi.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
> index 58012e1b5ae7..37b3534d0b0a 100644
> --- a/drivers/spi/spi-bcm63xx-hsspi.c
> +++ b/drivers/spi/spi-bcm63xx-hsspi.c
> @@ -889,8 +889,12 @@ static int bcm63xx_hsspi_suspend(struct device *dev)
>  {
>         struct spi_controller *host = dev_get_drvdata(dev);
>         struct bcm63xx_hsspi *bs = spi_controller_get_devdata(host);
> +       int ret;
> +
> +       ret = spi_controller_suspend(host);
> +       if (ret)
> +               return ret;
>
> -       spi_controller_suspend(host);
>         clk_disable_unprepare(bs->pll_clk);
>         clk_disable_unprepare(bs->clk);
>
> --
> 2.34.1
>

Acked-by: William Zhang <william.zhang@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature