[PATCH v2 0/2] irqchip/crossbar: Use correct index and fix resource leak
From: Bhargav Joshi
Date: Sat Jun 20 2026 - 08:10:06 EST
This series fixes two bugs in the TI irq-crossbar driver. These bugs
were recently flagged by the Sashiko AI bot during the review process
for the DT schema conversion of ti,irq-crossbar binding.
https://lore.kernel.org/linux-devicetree/20260605210647.CCC881F00893@xxxxxxxxxxxxxxx/
patch 1:
crossbar_domain_free() calls irq_domain_reset_irq_data() which zeros
d->hwirq before it is used as index to irq_map[]. subsequent accesses
use hwirq=0 which writes to the wrong slot. even if we would not reset
data crossbar_domain_free() uses crossbar source index as the index for
cb->irq_map and cb->write(), rather than the GIC SPI index. This can
cause out of out-of-bounds write.
patch 2:
fixes A resource leak where 'irq_domain_free_irqs_parent()' was never
called.
Signed-off-by: Bhargav Joshi <j.bhargav.u@xxxxxxxxx>
---
Changes in v2:
- Fixed subject and commit message.
- Added comment explaining parent_data->hwirq
- Link to v1: https://patch.msgid.link/20260610-irq-crossbar-fix-v1-0-26797369ff6a@xxxxxxxxx
---
Bhargav Joshi (2):
irqchip/crossbar: Use correct index in crossbar_domain_free()
irqchip/crossbar: Fix parent domain resource leak
drivers/irqchip/irq-crossbar.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
---
base-commit: 2d3090a8aeb596a26935db0955d46c9a5db5c6ce
change-id: 20260609-irq-crossbar-fix-43a7df653c6c
Best regards,
--
Bhargav