Re: [PATCH v2 2/4] rust: pci: add managed Device::enable_device()
From: Danilo Krummrich
Date: Sun Jun 21 2026 - 08:02:32 EST
On Sun Jun 21, 2026 at 12:19 AM CEST, Maurice Hieronymus wrote:
> Isn't it confusing when we only have `enable_device_managed` and
> `enable_device_mem_unmanaged` but not `enable_device_unmanaged` and
> `enable_device_mem_managed`?
I think we only need enable_device_managed() and a enable_device() /
disable_device() pair.
enable_device_managed() should be preferred, the unmanaged functions may still
be used for runtime PM.
The existing enable_device_mem() should just be removed and nova-core should use
enable_device_managed() in probe() instead.
If you are interested, feel free to create a small separate patch series making
those changes; you can stack this one on top of it.