Re: [PATCH 2/5] riscv: dts: spacemit: enable the i2c2 adapter on K3 Pico-ITX board

[Aurelien Jarno]

Both issues reported by Sashiko AI (see below) are valid, I'll submit a 
v2 fixing them, but I'll first leave a few more days for humans to also 
have a look at the patches.

Regards
Aurelien

On 2026-06-20 06:29, sashiko-bot@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Low] The pinctrl subnode is named `i2c2-0-pins` but belongs to the `i2c2-1-cfg` parent node.
> - [Low] Missing space before the assignment operator in `bias-pull-up= <0>;`.
> --
> 
> commit 4dc6c92d42831e85b38f3350c15707d0e2b3af18
> Author: Aurelien Jarno <aurelien@xxxxxxxxxxx>
> 
> riscv: dts: spacemit: enable the i2c2 adapter on K3 Pico-ITX board
> 
> This commit defines the I2C2 pinctrl properties and enables the adapter
> on the K3 Pico-ITX board. It will be used by the 24c02 eeprom.
> 
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> > index 23899d3f308a0..c9fe9c2e5aeee 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> > +++ b/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> 
> [ ... ]
> 
> > @@ -45,6 +45,17 @@ gmac0-phy-0-pins {
> >  		};
> >  	};
> >  
> > +	/omit-if-no-ref/
> > +	i2c2_1_cfg: i2c2-1-cfg {
> > +		i2c2-0-pins {
> 
> [Severity: Low]
> This isn't a bug, but should this subnode be named i2c2-1-pins to match
> the i2c2-1-cfg parent node? It seems to diverge from the standard naming
> pattern where the suffix of the parent and child matches.
> 
> > +			pinmux = <K3_PADCONF(46, 5)>,	/* i2c2 scl */
> > +				 <K3_PADCONF(47, 5)>;	/* i2c2 sda */
> > +
> > +			bias-pull-up= <0>;
> 
> [Severity: Low]
> This isn't a bug, but there is a missing space before the equals sign
> here, which diverges from the spacing used in the surrounding code.
> 
> > +			drive-strength = <25>;
> > +		};
> > +	};
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260620062238.3199108-1-aurelien@xxxxxxxxxxx?part=2
> 

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@xxxxxxxxxxx                     http://aurel32.net