Re: [GIT PULL] tracing: Updates for 7.2

From: Agatha Isabelle Moreira

Date: Sun Jun 21 2026 - 16:32:08 EST


On Fri, Jun 19, 2026 at 11:54:27AM -0400, Steven Rostedt wrote:
> On Fri, 19 Jun 2026 07:35:15 -0700
> Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> >
> > Now, if the same was true for printk(), I'd happily split that into
> > some other header too.
> >
> > But it isn't.
> >
> > Because we live in reality.
>

>
> Your patch now requires developers from remembering to add a
> #include <linux/trace_printk.h> in every file the touch. Or they may
> have to touch kernel.h triggering a full build as well. It moves burden
> from people who build the kernel and have to wait a little longer to
> developers that now need to remember to add includes that they didn't
> need to before!

Not only *add* a #include <linux/trace_printk.h>, but also remember to
not commit them later. If people eventually forget (of course nobody
ever forgets to do something in programming) and commit it and it goes
unnoticed in the review, we might end up with it included in several
places again, defeating the very purpose of this patch.

That would me easily solved with an #ifdef that would not only reduce
the #include bloat but also keep debugging comfortable.

--
Agatha Isabelle Moreira
Systems Engineer | C