Re: [PATCH] net/mlx5: Fix L3 tunnel entropy refcount leak

[Tariq Toukan]

On 13/06/2026 18:36, lirongqing wrote:
> From: Li RongQing <lirongqing@xxxxxxxxx>
>
> mlx5_tun_entropy_refcount_inc() counts both VXLAN and L2-to-L3
> tunnel reformat entries as entropy-enabling users. The matching
> decrement path only handled VXLAN, leaving L2-to-L3 tunnel entries
> counted after release.
>
> Handle MLX5_REFORMAT_TYPE_L2_TO_L3_TUNNEL in
> mlx5_tun_entropy_refcount_dec() as well so the enabling entry
> refcount remains balanced.
>
> Fixes: f828ca6a2fb6 ("net/mlx5e: Add support for hw encapsulation of MPLS over UDP")
> Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
> index 4571c56..97f6097 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c
> @@ -176,7 +176,8 @@ void mlx5_tun_entropy_refcount_dec(struct mlx5_tun_entropy *tun_entropy,
>   				   int reformat_type)
>   {
>   	mutex_lock(&tun_entropy->lock);
> -	if (reformat_type == MLX5_REFORMAT_TYPE_L2_TO_VXLAN)
> +	if (reformat_type == MLX5_REFORMAT_TYPE_L2_TO_VXLAN ||
> +	    reformat_type == MLX5_REFORMAT_TYPE_L2_TO_L3_TUNNEL)
>   		tun_entropy->num_enabling_entries--;
>   	else if (reformat_type == MLX5_REFORMAT_TYPE_L2_TO_NVGRE &&
>   		 --tun_entropy->num_disabling_entries == 0)

Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>