Re: [PATCH v3 05/13] drm/bridge: tc358762: Drop SPICMR write

[Tomi Valkeinen]

Hi,

On 21/06/2026 09:41, Andreas Kemnade wrote:
> On Fri, 19 Jun 2026 08:23:50 +0200
> Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:
>
> > On Wed, 13 May 2026 16:10:14 +0300
> > Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> wrote:
> >
> > > Drop write to SPICMR. It's unclear why the write is there, as SPI is not
> > > supported in the driver, and it's mostly just writing zeroes to already
> > > zero fields (reset defaults). None of the zero bits written disable
> > > anything wrt. SPI.
> > >
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> >   
> > Comparing it with something out of tree where SPI is apparently working.
> > It does not touch SPIMR,
> ok, looking what that code really does, it sets bit 1 called SPI_SEL_CS0,
> apparently in that register. But that belongs into an spi_init function.

Sorry, what sets bit 1? The write removed here just writes zeroes to a 
register that's all zero by default, so it's basically a no-op unless 
someone else has touched the register. And as SPI is not supported in 
the driver, I think it's better to drop the write to not give any false 
ideas of SPI support.

 Tomi