Re: [PATCH 1/6] USB: serial: ftdi_sio: add configurable inter-batch defer for read URBs

[Greg Kroah-Hartman]

On Mon, Jun 22, 2026 at 03:38:34PM +0800, Chinna Mopurigari Naveen Kumar Reddy wrote:
> +module_param(urb_defer_timer_ns, ulong, 0644);
> +MODULE_PARM_DESC(urb_defer_timer_ns,
> +		 "Inter-batch defer between read-URB resubmissions, in nanoseconds. 0 (default) disables the defer. Max 100000000 = 100 ms.");

This is not the 1990's, module parameters should not be used anymore as
they are not scalable or configurable or very well handled at all.

Please use a better abi if you really need this, BUT, I feel this is
totally the wrong place to do this.  You are assuming a single driver is
the source of the problem, when the real problem is the host controller
driver for this USB host.  Are you going to go and make this type of
change to every individual USB driver instead to paper over the
broken-ness of that USB host controller?

Why not just fix this at the root of the problem, that way you don't
have to modify all individual drivers at all?

thanks,

greg k-h