Re: [PATCH 3/3] staging: rtl8723bs: use usleep_range instead of msleep for short delays
From: Dan Carpenter
Date: Mon Jun 22 2026 - 05:15:38 EST
On Sun, Jun 21, 2026 at 01:40:58PM +0300, Serhat Kumral wrote:
> Replace msleep(10) and msleep(1) with usleep_range(10000, 20000) and
> usleep_range(1000, 2000) respectively in os_intfs.c, because msleep is
> imprecise and discouraged for short delays under 20ms.
> This fixes the checkpatch.pl warnings:
> WARNING: msleep < 20ms can sleep for up to 20ms; see function description of msleep().
>
> Signed-off-by: Serhat Kumral <serhatkumral1@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 89e41c26e..5e41f518a 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -986,7 +986,7 @@ void rtw_dev_unload(struct adapter *padapter)
> if (cnt > 5)
> break;
> cnt++;
> - msleep(10);
> + usleep_range(10000, 20000);
The first two are fine but this isn't. Do a search on lore for
the reasons.
regards,
dan carpenter