Re: [PATCH v2 4/4] hwspinlock: add summary in debugfs
From: Andy Shevchenko
Date: Mon Jun 22 2026 - 06:28:29 EST
On Mon, Jun 22, 2026 at 10:52:03AM +0200, Wolfram Sang wrote:
> Add a subsystem entry in debugfs and place a summary file there. It
> informs about registered locks, if they are in use, and to which device
> they belong. The state of the lock itself is usually not accessible
> without modifying the state, so there is no support for that.
...
> +#ifdef CONFIG_DEBUG_FS
Do we really need this? IIRC the compiler would be able to eliminate a dead
code for the cases CONFIG_DEBUG_FS=n.
> +#endif /* DEBUG_FS */
Otherwise LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko