Re: [PATCH v2 1/2] dt-bindings: power: supply: Add TI BQ25630 charger
From: Krzysztof Kozlowski
Date: Mon Jun 22 2026 - 07:07:31 EST
On Thu, Jun 18, 2026 at 03:37:59PM +0200, Waqar Hameed wrote:
> +allOf:
> + - $ref: power-supply.yaml#
> +
> +properties:
> + compatible:
> + const: ti,bq25630
> +
> + reg:
> + const: 0x6b
> + description:
> + Device I2C address.
Drop description, obvious.
> +
> + interrupts:
> + maxItems: 1
> + description: |
Do not need '|' unless you need to preserve formatting.
> + Device sends active low 256 µs pulse. Type should therefore be
> + IRQ_TYPE_EDGE_FALLING.
> +
> + monitored-battery: true
Drop this one
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - monitored-battery
> +
> +additionalProperties: false
And here use 'unevaluatedProperties: false' instead.
With these fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
Best regards,
Krzysztof