Re: [PATCH net v2] octeontx2-af: npc: cn20k: Fix subbank free list indexing for search order

[Simon Horman]

On Fri, Jun 19, 2026 at 03:21:00PM +0530, Ratheesh Kannoth wrote:
> subbank_srch_order[i] is the physical subbank at search-order slot i,
> so each subbank's arr_idx must be i (its slot), not
> subbank_srch_order[sb->idx].  The old logic mis-keyed xa_sb_free
> and broke allocation traversal order.
> 
> Populate arr_idx and xa_sb_free in a single pass over the search
> order after subbank structs are initialized.
> 
> Fixes: 7ac9d4c4075c ("octeontx2-af: npc: cn20k: add subbank search order control")
> Signed-off-by: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>
> 
> ---
> v1 -> v2: Addressed simon comments
> 	https://lore.kernel.org/netdev/20260619091341.918165-1-horms@xxxxxxxxxx/

Thanks for the update.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

FTR, I think the issue flagged in the AI-generated review of this
patch on sashiko.org can be treated in the context of possible follow-up.
I don' think it should impede the progress of this patch.