Re: [PATCH v3] ASoC: tas2783: Update loaded firmware names to linux-firmware 20260519

[Mark Brown]

On Sun, Jun 21, 2026 at 04:00:01PM +0200, Bartosz Juraszewski wrote:
> In linux-firmware commit from 2026-05-19 `2f90f4fe5c67f51a8410907a...`
> `ASoC: tas2783: Add Firmware files for tas2783A projects` by Baojun Xu
> 138 new firmware files for tas2783 were added, none of which are loaded

> +{
> +	s32 ret;
> +	u8 unique_id = tas_dev->sdw_peripheral->id.unique_id;
> +
> +	tas_generate_fw_name(slave, tas_dev->rca_binaryname,
> +			     sizeof(tas_dev->rca_binaryname));
> +
> +	ret = request_firmware_nowait(THIS_MODULE, FW_ACTION_UEVENT,
> +				      tas_dev->rca_binaryname, tas_dev->dev,
> +				      GFP_KERNEL, tas_dev, tas2783_fw_ready);
> +	if (ret) {
> +		dev_err(tas_dev->dev,
> +			"firmware request failed for uid=%d, ret=%d\n",
> +			unique_id, ret);
> +		return ret;
> +	}
> +
> +	ret = wait_event_timeout(tas_dev->fw_wait, tas_dev->fw_dl_task_done,
> +				 msecs_to_jiffies(TIMEOUT_FW_DL_MS));

You need to reset fw_dl_task_done for each run through this, _fw_ready()
will set it unconditionally so if the first attempt to load fails the
second attempt will see the flag already set and not actually need to
wait.

Attachment: signature.asc
Description: PGP signature