Re: [PATCH v2 12/13] mm: Move __alloc_pages() to mm/internal.h

[Lorenzo Stoakes]

On Mon, Jun 22, 2026 at 02:24:36PM +0200, David Hildenbrand (Arm) wrote:
> On 6/22/26 12:01, Brendan Jackman wrote:
> > It's no longer used outside of mm/.
> >
> > Since this means __alloc_pages_noprof() is no longer visible from gfp.h,
> > this also means moving the definition of alloc_pages_node_noprof into
> > the .c file.
> >
> > Signed-off-by: Brendan Jackman <jackmanb@xxxxxxxxxx>
> > ---
> >  Documentation/admin-guide/cgroup-v1/cpusets.rst |  2 +-
> >  Documentation/admin-guide/mm/transhuge.rst      |  2 +-
> >  include/linux/gfp.h                             | 16 +---------------
> >  mm/internal.h                                   |  4 ++++
> >  mm/page_alloc.c                                 | 11 +++++++++++
> >  5 files changed, 18 insertions(+), 17 deletions(-)
>
> Do we want some mm/page_alloc.h , to start splitting up mm/internal.h

Yes please!

>
> --
> Cheers,
>
> David