Re: [PATCH] fsl/fman: Free init resources on KeyGen failure in fman_init()

[Pavan Chebbi]

On Mon, Jun 22, 2026 at 4:47 PM Haoxiang Li <haoxiang_li2024@xxxxxxx> wrote:
>
> fman_muram_alloc() allocates initialization resources before
> initializing the KeyGen block. If keygen_init() fails, the
> function returns -EINVAL directly and leaves those resources
> allocated. Free the initialization resources before returning
> from the KeyGen failure path.
>
> While at it, drop the unused error check around enable(), which
> always returns 0.
>
> Fixes: 7472f4f281d0 ("fsl/fman: enable FMan Keygen")
> Cc: stable@xxxxxxxxxx
> Signed-off-by: Haoxiang Li <haoxiang_li2024@xxxxxxx>
> ---
>  drivers/net/ethernet/freescale/fman/fman.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>

LGTM. Note that you should add "net" to the fixes patch titles.
Otherwise you see patch automation has guessed this one for net-next.
Reviewed-by: Pavan Chebbi <pavan.chebbi@xxxxxxxxxxxx>

> diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c
> index 013273a2de32..3a2a57207e55 100644
> --- a/drivers/net/ethernet/freescale/fman/fman.c
> +++ b/drivers/net/ethernet/freescale/fman/fman.c
> @@ -1995,12 +1995,12 @@ static int fman_init(struct fman *fman)
>
>         /* Init KeyGen */
>         fman->keygen = keygen_init(fman->kg_regs);
> -       if (!fman->keygen)
> +       if (!fman->keygen) {
> +               free_init_resources(fman);
>                 return -EINVAL;
> +       }
>
> -       err = enable(fman, cfg);
> -       if (err != 0)
> -               return err;
> +       enable(fman, cfg);
>
>         enable_time_stamp(fman);
>
> --
> 2.25.1
>
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature