Re: [PATCH v1] kernel: add a simple timer based software watchpoint

[David Hildenbrand (Arm)]

>>> This provides the basic function, and there are more todoes:
>>>   * add a ftrace mode to do function level monitoring with ftrace hook,
>>>     which is more accurate timing wise, as suggested by Steven Rostedt
>>>   * merge the dram/mmio interface to auto detect it's dram or mmio
>>>   * support runtime changing the address
>>>   * move the starting point earlier in boot phase
>>>   * monitor a whole memory region
>>>   * currently is monitoring 'changing to a value', add support
>>>     for 'changing from a value'
>>
>> That really looks more like the kind of thing you would want to carry as a OOT
>> hack for your special debugging needs :)
> 
> Thanks for the review and bringing up a very good question that whether
> the patch is worthy!
> 
> Personally, I think it is.  

The problem is that the interface is odd (kernel parameters) and the
implementation is shaky (what happens if memory does not exist? What happens if
we unplug memory?).

I don't think it's a good use of our time to polish all that up and then
maintain it.

-- 
Cheers,

David