Re: [PATCH 1/5] soundwire: Move wait for initialisation helper to header
From: Charles Keepax
Date: Mon Jun 22 2026 - 11:19:23 EST
On Mon, Jun 22, 2026 at 04:08:54PM +0100, Mark Brown wrote:
> On Sat, Jun 20, 2026 at 12:02:33PM +0100, Charles Keepax wrote:
>
> > As SoundWire devices tend to enumerate on the bus after probe, drivers
> > frequently need to wait for the device to initialise from common driver
> > code. The common system is to split drivers into a core module and then
>
> > +static inline int sdw_slave_wait_for_init(struct sdw_slave *slave, int timeout_ms)
> > +{
> > + unsigned long time;
> > +
> > + if (!slave)
> > + return 0;
> > +
> > + time = wait_for_completion_timeout(&slave->initialization_complete,
> > + msecs_to_jiffies(timeout_ms));
>
> You need to add an include of linux/jiffies.h for msecs_to_jiffies()
> otherwise we might get build breaks.
Good shout thanks I will do a respin.
Thanks,
Charles