Re: [PATCH 04/13] Bluetooth: btusb: QCA: Do not populate devcoredump fields on ATH3012 or QCA_ROME

[Dmitry Baryshkov]

On Mon, Jun 22, 2026 at 07:52:17AM -0700, Zijun Hu wrote:
> Devcoredump is disabled on ATH3012 or QCA_ROME, but btusb_setup_qca()
> used by both unconditionally populates those two devcoredump fields.
> 
> Fix by populating devcoredump fields only for BTUSB_QCA_WCN6855 devices,
> which are the only ones that enable devcoredump.

Why? Wouldn't it be better to enable devcoredump for all platforms?

> 
> Signed-off-by: Zijun Hu <zijun.hu@xxxxxxxxxxxxxxxx>
> ---
>  drivers/bluetooth/btusb.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 6a90f012b226..184a87d1234c 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -3708,8 +3708,10 @@ static int btusb_setup_qca(struct hci_dev *hdev)
>  	if (err < 0)
>  		return err;
>  
> -	btdata->qca_dump.fw_version = le32_to_cpu(ver.patch_version);
> -	btdata->qca_dump.controller_id = le32_to_cpu(ver.rom_version);
> +	if (btdata->match_id->driver_info & BTUSB_QCA_WCN6855) {
> +		btdata->qca_dump.fw_version = le32_to_cpu(ver.patch_version);
> +		btdata->qca_dump.controller_id = le32_to_cpu(ver.rom_version);
> +	}
>  
>  	if (!(status & QCA_SYSCFG_UPDATED)) {
>  		err = btusb_setup_qca_load_nvm(hdev, &ver, info);
> 
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry