[PATCH v2 3/5] media: i2c: msp3400-driver: Add missing media_entity_cleanup()
From: Biren Pandya
Date: Mon Jun 22 2026 - 14:53:37 EST
The remove function and the probe error path are missing calls to
media_entity_cleanup(). Add them.
Signed-off-by: Biren Pandya <birenpandya@xxxxxxxxx>
---
drivers/media/i2c/msp3400-driver.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/msp3400-driver.c b/drivers/media/i2c/msp3400-driver.c
index 4c0b0ad68c08..48c60050c5d7 100644
--- a/drivers/media/i2c/msp3400-driver.c
+++ b/drivers/media/i2c/msp3400-driver.c
@@ -717,6 +717,7 @@ static int msp_probe(struct i2c_client *client)
if (state->rev1 == -1 || (state->rev1 == 0 && state->rev2 == 0)) {
dev_dbg_lvl(&client->dev, 1, msp_debug,
"not an msp3400 (cannot read chip version)\n");
+ media_entity_cleanup(&sd->entity);
return -ENODEV;
}
@@ -812,6 +813,7 @@ static int msp_probe(struct i2c_client *client)
int err = hdl->error;
v4l2_ctrl_handler_free(hdl);
+ media_entity_cleanup(&sd->entity);
return err;
}
@@ -865,6 +867,7 @@ static void msp_remove(struct i2c_client *client)
msp_reset(client);
v4l2_ctrl_handler_free(&state->hdl);
+ media_entity_cleanup(&state->sd.entity);
}
/* ----------------------------------------------------------------------- */
--
2.50.1 (Apple Git-155)