Re: [PATCH 1/3] ksmbd: fix sd_ndr.data memory leak in ksmbd_vfs_set_sd_xattr

[ChenXiaoSong]

Looks good. Feel free to add:
Reviewed-by: ChenXiaoSong <chenxiaosong@xxxxxxxxxx>

On 6/23/26 10:12, liuqiangneo@xxxxxxx wrote:
> From: Qiang Liu <liuqiang@xxxxxxxxxx>
>
> Move kfree(sd_ndr.data) into the out cleanup path to avoid memory
> leak on error.
>
> Signed-off-by: Qiang Liu <liuqiang@xxxxxxxxxx>
> ---
>   fs/smb/server/vfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
> index 74b0307cb100..febe9f7b54c3 100644
> --- a/fs/smb/server/vfs.c
> +++ b/fs/smb/server/vfs.c
> @@ -1479,8 +1479,8 @@ int ksmbd_vfs_set_sd_xattr(struct ksmbd_conn *conn,
>   	if (rc < 0)
>   		pr_err("Failed to store XATTR ntacl :%d\n", rc);
>   
> -	kfree(sd_ndr.data);
>   out:
> +	kfree(sd_ndr.data);
>   	kfree(acl_ndr.data);
>   	kfree(smb_acl);
>   	kfree(def_smb_acl);

--
ChenXiaoSong <chenxiaosong@xxxxxxxxxxxxxxxx>
Chinese Homepage: https://chenxiaosong.com
English Homepage: https://chenxiaosong.com/en