Re: [PATCH v4 01/13] clk: qcom: gcc-qcm2290: Keep the critical clocks always-on from probe

[Imran Shaik]

On 22-06-2026 08:42 pm, Dmitry Baryshkov wrote:
> On Sun, 21 Jun 2026 at 16:28, Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx> wrote:
> > On 06-06-2026 04:54 pm, Dmitry Baryshkov wrote:
> > > On Thu, Jun 04, 2026 at 10:56:07AM +0530, Imran Shaik wrote:
> > > > Some GCC branch clocks are required to be kept always-on due to the
> > > > hardware requirements. Drop the modelling of those always-on QCM2290 GCC
> > > > clocks and use the latest .clk_cbcr convention to keep them enabled from
> > > > probe.
> > >
> > > You got the feedback, but it got ignored. There is no explanation about
> > > gcc_gpu_iref_clk and several other clocks becoming always on.
> >
> > Apologies for the late reply.
> >
> > I have updated generically that few clocks are required to be kept ON
> > due to the hardware requirements. For gcc_gpu_iref_clk clock the
> > Power-On-Reset value is default ON, and such clocks are kept ON from
> > probe. As Agatti is working functionally, I will keep this clock
> > modelling same as before.
> >
> > And I will update commit text that the GCC video ahb/xo clocks are
> > required to be kept ON similar to other camera/disp ahb/xo clocks.
>
> Why? What is _wrong_ with thow they are modelled now?

Usually this is required for the register access, hence we mark them 
critical and keep them ON. As it is working on Agatti with the 
modelling, will keep them as is for now.

Thanks,
Imran