Re: [PATCH 1/2] phy: qcom: edp: split power-on sequencing by PHY version
From: Konrad Dybcio
Date: Tue Jun 23 2026 - 03:37:44 EST
On 6/23/26 1:29 AM, Bjorn Andersson wrote:
> The eDP PHY power-on sequence has grown version-specific differences,
> but qcom_edp_phy_power_on() still contains the sequence as one shared
> flow. This makes it difficult to add newer PHY programming without
> interleaving it with the v4/v6 sequence.
>
> Split the power-on sequence into version callbacks for the parts that
> differ between PHY revisions:
>
> - pre-power-on preparation
> - TX programming before PLL enable
> - rate/PCS programming
> - lane programming after PLL enable
> - final status polling
>
> Keep the existing v4/v6 sequence as the v46 implementation, and wire v8
> to the same callbacks for now. This keeps the programming unchanged
> while making the next patch a v8-only programming update.
>
> Assisted-by: Codex:GPT-5.5
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxxxx>
> ---
Look like indeed it's a NOP, as hard as it may be to deduce from the
diff:
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad