Re: [PATCH net] net: bcmgenet: report MDIO busy timeout

[Andrew Lunn]

On Tue, Jun 23, 2026 at 02:15:24PM +0800, Pengpeng Hou wrote:
> bcmgenet_mii_wait() waits for the UNIMAC MDIO command busy bit to clear,
> but ignores wait_event_timeout() and always returns success.
> 
> Return -ETIMEDOUT when the busy bit remains set for the whole wait
> period so MDIO callers see the failed transaction instead of continuing
> as if the bus were idle.

MDIO is a very simple bus, basically a shift register, clocked at a
fixed rate, no possible protocol failure scenarios.

Have you actually seen this timeout occur? Or is this theoretical,
from code inspection?

We are getting lots and lots of theoretical issues reported and fixed,
while very few new developers are contributing new code, new
features. Please could you try to concentrate on things which actually
matter? Theoretical issues just waist Reviewer and Maintainer time.

Also, the merge window is open at the moment. You need to repost when
it closes:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew