Re: [PATCH 2/3] scsi: ufs: core: Tolerate RX_FOM read failures in TX EQTR

[Peter Wang (王信友)]

On Sat, 2026-06-20 at 01:03 -0700, Can Guo wrote:
> @@ -494,22 +496,30 @@ static int ufshcd_get_rx_fom(struct ufs_hba
> *hba,
> 
>         /* Get FOM of host's TX lanes from device's RX_FOM. */
>         for (lane = 0; lane < pwr_mode->lane_tx; lane++) {
> +               h_iter->fom[lane] = 0;
>                 ret = ufshcd_dme_peer_get(hba,
> UIC_ARG_MIB_SEL(RX_FOM,
>                                          
> UIC_ARG_MPHY_RX_GEN_SEL_INDEX(lane)),
>                                           &fom);
> -               if (ret)
> -                       return ret;
> +               if (ret) {
> +                       dev_dbg(hba->dev, "Failed to get FOM for Host
> TX Lane %d: %d\n",
> +                               lane, ret);
> +                       continue;
> +               }
> 

Hi Can,

I suggest setting h_iter->fom[lane] = 0 when an error occurs, 
as this approach is clearer and improves code efficiency, 
for example:
if (ret) {
    h_iter->fom[lane] = 0;
    ...
    continue;
}


>                 h_iter->fom[lane] = (u8)fom;
>         }
> 
>         /* Get FOM of device's TX lanes from host's RX_FOM. */
>         for (lane = 0; lane < pwr_mode->lane_rx; lane++) {
> +               d_iter->fom[lane] = 0;
>                 ret = ufshcd_dme_get(hba, UIC_ARG_MIB_SEL(RX_FOM,
>                                     
> UIC_ARG_MPHY_RX_GEN_SEL_INDEX(lane)),
>                                      &fom);
> -               if (ret)
> -                       return ret;
> +               if (ret) {
> +                       dev_dbg(hba->dev, "Failed to get FOM for
> Device TX Lane %d: %d\n",
> +                               lane, ret);
> +                       continue;
> +               }
> 

The same applies as above.

Thanks
Peter