Re: [PATCH] [net] eth: mlx5: fix macsec dependency

[Sabrina Dubroca]

2026-06-22, 14:41:07 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Configurations with mlx5 built-in but macsec=m fail to link:
> 
> x86_64-linux-ld: drivers/infiniband/hw/mlx5/macsec.o: in function `mlx5r_add_gid_macsec_operations':
> macsec.c:(.text+0x77d): undefined reference to `macsec_netdev_is_offloaded'
> x86_64-linux-ld: drivers/infiniband/hw/mlx5/macsec.o: in function `mlx5r_del_gid_macsec_operations':
> macsec.c:(.text+0xe81): undefined reference to `macsec_netdev_is_offloaded'
> 
> Fix the dependency so this configuration cannot happen.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx>

>  drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

...
> @@ -144,7 +144,7 @@ config MLX5_CORE_IPOIB
>  config MLX5_MACSEC
>  	bool "Connect-X support for MACSec offload"
>  	depends on MLX5_CORE_EN
> -	depends on MACSEC
> +	depends on MACSEC=y || MACSEC=MLX5_CORE

I'd never seen this 'configA=configB' syntax, cool.

-- 
Sabrina