Re: [PATCH v2] bus: qcom-ebi2: use managed resources for clocks and children

[Linus Walleij]

On Tue, Jun 23, 2026 at 3:54 AM Pengpeng Hou <pengpeng@xxxxxxxxxxx> wrote:

> qcom_ebi2_probe() enables the EBI2 clocks manually and populates child
> devices manually. Several later failure paths can then return without
> disabling the clocks or without relying on the driver core to undo child
> population.
>
> Use devm_clk_get_enabled() for both clocks and
> devm_of_platform_populate() for children. This lets the driver core
> unwind the resources automatically and removes the hand-written error
> labels.
>
> Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>

This looks good to me:
Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij