Re: [PATCH v2 0/3] staging: media: atomisp: use kvmalloc_objs() and drop redundant OOM messages

[Andy Shevchenko]

On Mon, Jun 22, 2026 at 07:42:41PM -0300, Rodrigo Gobbi wrote:
> Several allocations in the atomisp driver still size their buffers with
> open-coded multiplication, e.g. width * height * sizeof(*p). When the
> dimensions are large the product can silently wrap, causing kvmalloc()
> to allocate an undersized buffer.
> 
> Convert the remaining sites to kvmalloc_objs() with array_size(), which
> saturate to SIZE_MAX on overflow so kvmalloc() returns NULL instead of
> allocating too few bytes.
> 
> This continues the work started in commit [2], and picks up the stalled
> sites from [1], unifying with [3].
> 
> While here, drop the redundant IA_CSS_ERROR("out of memory") messages on
> the touched allocation paths: the memory management core already emits a
> far more detailed warning on allocation failure as raised at [1].

> [1] https://lore.kernel.org/all/20260413112904.98864-1-feng@xxxxxxxxx/
> [2] https://github.com/torvalds/linux/commit/d178c7ca8fefc28115d35b94c3b1f4d653e34182
> [3] https://lore.kernel.org/all/20260609215110.118860-1-rodrigo.gobbi.7@xxxxxxxxx/
> ---
> Hi, all,
> Regarding a comment from Andy at [3]:

> > There is a ongoing effort like this for other files from atomisp
> > at [1], yet, it is not covering the same file.

> > [1] https://lore.kernel.org/all/20260413112904.98864-1-feng@xxxxxxxxx/
> 
> > Yeah, the problem is that the activity seems stale. Can you pickup all
> > the patches from the mailing list that have not been yet applied (regarding
> > k*alloc() uses) and combine them into series or so and update regarding to
> > Sakari's comments?
> The only patches that I found from stale threads were added in this series,
> hope that is fine now.

You need to preserve the original authors.
Also see individual comments.

-- 
With Best Regards,
Andy Shevchenko