Re: [PATCH] usb: dwc3: fix dwc3_readl() and dwc3_writel() calls in dwc3_ulpi_setup()

[Ben Dooks]

On 23/06/2026 10:51, Ben Dooks wrote:
> The dwc3_ulpi_setup() calls the register read and write calls with
> dwc3->regs when both these calls take the dwc3 structure directly.
>
> Chnage these two calls to fix the following sparse warning, and
> possibly a nasty bug in the dwc3_ulpi_setup() code:
>
> drivers/usb/dwc3/core.c:796:45: warning: incorrect type in argument 1 (different address spaces)
> drivers/usb/dwc3/core.c:796:45:    expected struct dwc3 *dwc
> drivers/usb/dwc3/core.c:796:45:    got void [noderef] __iomem *regs
> drivers/usb/dwc3/core.c:798:40: warning: incorrect type in argument 1 (different address spaces)
> drivers/usb/dwc3/core.c:798:40:    expected struct dwc3 *dwc
> drivers/usb/dwc3/core.c:798:40:    got void [noderef] __iomem *regs
>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> ---
>   drivers/usb/dwc3/core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 517aa7f1486d..f5e60fb1a5cc 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -789,9 +789,9 @@ static void dwc3_ulpi_setup(struct dwc3 *dwc)
>   
>   	if (dwc->enable_usb2_transceiver_delay) {
>   		for (index = 0; index < dwc->num_usb2_ports; index++) {
> -			reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(index));
> +			reg = dwc3_readl(dwcs, DWC3_GUSB2PHYCFG(index));

oops, failed to ammend the typo fix for this, will re-send

>   			reg |= DWC3_GUSB2PHYCFG_XCVRDLY;
> -			dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(index), reg);
> +			dwc3_writel(dwc, DWC3_GUSB2PHYCFG(index), reg);
>   		}
>   	}
>   }


--
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html