Re: Re: [PATCH] clk: eswin: Add CLK_IGNORE_UNUSED to NoC clock

[Brian Masney]

On Tue, Jun 23, 2026 at 2:58 AM Xuyang Dong
<dongxuyang@xxxxxxxxxxxxxxxxxx> wrote:
> > Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>
> >
> > FYI, I posted a series to implement sync_state support for the clk
> > subsystem, which should fix these type of issues for the long term. If
> > you happen to have time, I would appreciate it if you have time to test
> > this series on your hardware, and drop a Tested-by.
> >
> > https://lore.kernel.org/linux-clk/20260603-clk-sync-state-v1-0-457120eed200@xxxxxxxxxx/
> >
> > I have a new series ready that I'm planning to post tomorrow. I'm
> > waiting to hear back about the ongoing conversation on that thread.
> >
> > Once this lands, there shouldn't be much need for the CLK_IGNORE_UNUSED
> > flag. I'm curious if you revert this patch in your tree if the need for the
> > flag goes away with the sync_state changes applied.
> >
> > Let's get your change in the tree though. If we merged sync_state today,
> > it won't be eligible to be backported to the stable kernels, and the
> > CLK_IGNORE_UNUSED flag is an easier backport.
> >
>
> Hi Brian,
>
> Thank you for your patch set above. However, we still need this fix patch
> at the moment, because gate_noc_nsp_clk still needs to be enabled when
> accessing PCIe.

Yes, I agree this is also needed.

Brian