Re: [PATCH v2] ASoC: soc-core: Create device_link to ensure correct suspend order

[Richard Fitzgerald]

On 22/6/26 08:07, Marek Szyprowski wrote:
> On 20.06.2026 17:57, Richard Fitzgerald wrote:
> > On 17/6/26 15:10, Marek Szyprowski wrote:
> > > On 11.06.2026 13:08, Richard Fitzgerald wrote:
> > > > In snd_soc_bind_card() create a device_link from card to all components
> > > > to ensure correct order of system_suspend. The card is the consumer and
> > > > the components are the supplier, so that the card will system_suspend
> > > > before any of the components.
> >
> > <SNIP>
> >
> > > This patch landed recently in linux-next as commit 0f54ce994b23 ("ASoC:
> > > soc-core: Create device_link to ensure correct suspend order"). In my
> > > tests I found that it breaks probing of VC4 DRM subsystem on Raspberry Pi
> > > 3 and 4 boards due to an issue with hdmi-audio-codec:
> > >
> > > # dmesg | grep vc4
> > > vc4-drm gpu: bound fe400000.hvs (ops vc4_hvs_ops [vc4])
> > > vc4_hdmi fef00700.hdmi: Failed to create device link to hdmi-audio-codec.1.auto
> > > vc4_hdmi fef00700.hdmi: error -EINVAL: Could not register sound card
> > > vc4-drm gpu: failed to bind fef00700.hdmi (ops vc4_hdmi_ops [vc4]): -22
> > > vc4-drm gpu: adev bind failed: -22
> > > vc4-drm gpu: probe with driver vc4-drm failed with error -22
> > Marek,
> >
> > Can you try the patch below?
> >
> > If this works for you, and passes our tests, and nobody has any
> > objections, I can send it as a proper patch submission.
>
>
> The patch was completely malformed (broken lines, tabs vs. spaces), I had to apply
> it manually line by line, but it fixed the issue I've observed:

Sorry. I forgot that copy-pasting it into an email would do line
wrapping