Re: [PATCH v3 4/4] cpufreq: ACPI: Use amd_update_hwcr() for MSR_K7_HWCR updates

[Rafael J. Wysocki]

On Fri, Jun 19, 2026 at 12:45 AM Jim Mattson <jmattson@xxxxxxxxxx> wrote:
>
> For consistency and maintainability, update boost_set_msr() to use
> the centralized amd_update_hwcr() helper when modifying MSR_K7_HWCR.
>
> Suggested-by: Borislav Petkov <bp@xxxxxxxxx>
> Assisted-by: Gemini:gemini-3.5-pro
> Signed-off-by: Jim Mattson <jmattson@xxxxxxxxxx>

Acked-by: Rafael J. Wysocki (Intel) <rafael@xxxxxxxxxx>

> ---
>  drivers/cpufreq/acpi-cpufreq.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 48d678812fd6..b3e058dd6b4b 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -103,9 +103,7 @@ static int boost_set_msr(bool enable)
>                 break;
>         case X86_VENDOR_HYGON:
>         case X86_VENDOR_AMD:
> -               msr_addr = MSR_K7_HWCR;
> -               msr_mask = MSR_K7_HWCR_CPB_DIS;
> -               break;
> +               return amd_update_hwcr(MSR_K7_HWCR_CPB_DIS_BIT, !enable);
>         default:
>                 return -EINVAL;
>         }
> --
> 2.55.0.rc0.799.gd6f94ed593-goog
>