Re: [PATCH] virtio_console: fix endian conversion in handle_control_message()
From: Amit Shah
Date: Tue Jun 23 2026 - 08:24:27 EST
On Tue, 2026-06-23 at 10:21 +0100, Ben Dooks wrote:
> There are a couple of prints in handle_control_message() which should
> have converted cpkt->id through virtio32_to_cpu() before passing to
> a print.
>
> This fixes the following (prototype) sparse warnings:
> drivers/char/virtio_console.c:1538:17: warning: incorrect type in
> argument 4 (different base types)
> drivers/char/virtio_console.c:1538:17: expected unsigned int
> drivers/char/virtio_console.c:1538:17: got restricted __virtio32
> [usertype] id
> drivers/char/virtio_console.c:1553:25: warning: incorrect type in
> argument 3 (different base types)
> drivers/char/virtio_console.c:1553:25: expected unsigned int
> drivers/char/virtio_console.c:1553:25: got restricted __virtio32
> [usertype] id
>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
Reviewed-by: Amit Shah <amit@xxxxxxxxxx>
Amit