Re: [PATCH] cpufreq: powernow-k6: replace symbolic permissions with octal

[Rafael J. Wysocki]

On Sat, Jun 13, 2026 at 7:16 PM Jack Lee <skunkolee@xxxxxxxxx> wrote:
>
> Symbolic permissions S_IRUGO are not preferred. Replace with octal
> permissions 0444 as recommended by checkpatch.
>
> Signed-off-by: Jack Lee <skunkolee@xxxxxxxxx>

I don't see a good enough reason for making this change, sorry.

First, checkpatch.pl messages regarding the existing code are irrelevant.

Second, this particular driver is in a deep maintenance mode and the
particular update in question is not significant enough for touching
it IMV.

> ---
>  drivers/cpufreq/powernow-k6.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/powernow-k6.c b/drivers/cpufreq/powernow-k6.c
> index 99d2244e03b0..764907b04c04 100644
> --- a/drivers/cpufreq/powernow-k6.c
> +++ b/drivers/cpufreq/powernow-k6.c
> @@ -29,10 +29,10 @@ static unsigned int                     max_multiplier;
>  static unsigned int                    param_busfreq = 0;
>  static unsigned int                    param_max_multiplier = 0;
>
> -module_param_named(max_multiplier, param_max_multiplier, uint, S_IRUGO);
> +module_param_named(max_multiplier, param_max_multiplier, uint, 0444);
>  MODULE_PARM_DESC(max_multiplier, "Maximum multiplier (allowed values: 20 30 35 40 45 50 55 60)");
>
> -module_param_named(bus_frequency, param_busfreq, uint, S_IRUGO);
> +module_param_named(bus_frequency, param_busfreq, uint, 0444);
>  MODULE_PARM_DESC(bus_frequency, "Bus frequency in kHz");
>
>  /* Clock ratio multiplied by 10 - see table 27 in AMD#23446 */
> --
> 2.54.0
>