Re: [PATCH v1 1/2] drm/xe/i2c: Handler for SMBus Alerts

[Raag Jadav]

On Mon, Jun 22, 2026 at 01:47:58PM +0200, Heikki Krogerus wrote:
> Some devices that are attached to the I2C controller use the
> SMBus Alert signal for example to inform the host about
> thermal events, so registering the default SMBus Alert
> device device for them. The alert device makes sure that

Nit: Duplicate 'device' ;)

> the alert is processed and passed to the correct I2C client
> driver.

...

> @@ -182,7 +183,10 @@ void xe_i2c_irq_handler(struct xe_device *xe, u32 master_ctl)
>  		return;
>  
>  	/* Forward interrupt to I2C adapter */
> -	generic_handle_irq_safe(xe->i2c->adapter_irq);
> +	if (xe->i2c->smbus_alert)
> +		xe_i2c_handle_smbus_alert(xe->i2c);
> +	else
> +		generic_handle_irq_safe(xe->i2c->adapter_irq);

This looks like the else case will never hit since no other platform
supports irq. Is it on the cards at some point or can we make it obsolete?

Raag