Re: [PATCH] iio: imu: st_lsm6dsx: deselect shub page before reading whoami
From: Andreas Kempe
Date: Tue Jun 23 2026 - 11:30:18 EST
Den Fri, Jun 05, 2026 at 03:13:20PM +0100, skrev Jonathan Cameron:
> On Fri, 5 Jun 2026 13:44:59 +0000
> Andreas Kempe <andreas.kempe@xxxxxxxx> wrote:
> >
> > The reason I put the fix where it is, is because
> > st_lsm6dsx_check_whoami() is what assigns hw->settings needed for
> > st_lsm6dsx_set_page() to work. I moved that assignment to before the
> > whoami check for that very reason.
> >
> > As I see it, moving my fix to a more reasonable place would mean a
> > larger restructuring of the driver or making the whoami check advisory
> > per your suggestion.
>
> That feels unwise (even though it would work) as a fix for this issue.
> People would get very confused at the informational print.
>
> Ok. I guess maybe this is the best we can do.
>
> Lets see if Lorenzo is happy with earlier part of this thread
>
A friendly ping to Lorenzo on this topic.
Best regards,
Andreas Kempe