Re: [PATCH v2 1/3] usb: typec: Add helper to check cable altmode support

From: Andrei Kuchynski

Date: Tue Jun 23 2026 - 11:38:12 EST


if you are not against it

On Tue, Jun 23, 2026 at 10:30 AM Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
>
> One day and I'm completely confused again :). I opened the code for
> myself (not compiled) to get the idea again. Please consider that, or
> something like it - the important part for me is the enum. The enum
> does not cost that many lines, but it does make the idea more clear,
> at least for me.
>

Thank you for such a detailed look.
The code not only compiles, but it actually works as expected)

> case IDH_PTYPE_PCABLE:
> if (speed == CABLE_USB2_ONLY)
> return CABLE_NOT_SUPPORTED;
> break;

With one change: `return CABLE_SUPPORTED;` instead of `break` here.

So, the enum and the wrapper are in V3.
If you don't mind, I'll add you to the "Co-Developers" list.

Thanks,
Andrei