Re: [PATCH 2/2] mm/mprotect: drop 'sub' from batching context

[Lorenzo Stoakes]

On Tue, Jun 23, 2026 at 12:57:22PM +0000, Dev Jain wrote:
> Shorten the name of page_anon_exclusive_sub_batch by dropping the
> "sub-batch" context - the function itself doesn't need this context.
> Similarly, drop "sub" from sub_batch_idx, it is unnecessary and the
> usage is clear enough.
>
> Signed-off-by: Dev Jain <dev.jain@xxxxxxx>

LGTM, so:

Reviewed-by: Lorenzo Stoakes <ljs@xxxxxxxxxx>

> ---
>  mm/mprotect.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index 9cbf932b028cf..c0f5ab74bee23 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -143,7 +143,7 @@ static __always_inline void prot_commit_flush_ptes(struct vm_area_struct *vma,
>   * !PageAnonExclusive() pages, starting from start_idx. Caller must enforce
>   * that the ptes point to consecutive pages of the same anon large folio.
>   */
> -static __always_inline int page_anon_exclusive_sub_batch(int start_idx, int max_len,
> +static __always_inline int page_anon_exclusive_batch(int start_idx, int max_len,
>  		struct page *first_page, bool expected_anon_exclusive)
>  {
>  	int idx;
> @@ -174,16 +174,16 @@ static __always_inline void commit_anon_folio_batch(struct vm_area_struct *vma,
>  		pte_t oldpte, pte_t ptent, int nr_ptes, struct mmu_gather *tlb)
>  {
>  	bool expected_anon_exclusive;
> -	int sub_batch_idx = 0;
> +	int batch_idx = 0;
>  	int len;
>
>  	while (nr_ptes) {
> -		expected_anon_exclusive = PageAnonExclusive(first_page + sub_batch_idx);
> -		len = page_anon_exclusive_sub_batch(sub_batch_idx, nr_ptes,
> +		expected_anon_exclusive = PageAnonExclusive(first_page + batch_idx);
> +		len = page_anon_exclusive_batch(batch_idx, nr_ptes,
>  					first_page, expected_anon_exclusive);
>  		prot_commit_flush_ptes(vma, addr, ptep, oldpte, ptent, len,
> -				       sub_batch_idx, expected_anon_exclusive, tlb);
> -		sub_batch_idx += len;
> +				       batch_idx, expected_anon_exclusive, tlb);
> +		batch_idx += len;
>  		nr_ptes -= len;
>  	}
>  }
> --
> 2.43.0
>