Re: [PATCH v3 1/8] hwmon/misc: amd-sbi: Move core sbtsi support from hwmon to misc

[Julian Braha]

Hi Akshay,

On 6/22/26 14:58, Akshay Gupta wrote:

> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index e4c4f2b09732..8f204cf49b6e 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1963,7 +1963,7 @@ config SENSORS_SL28CPLD
>  
>  config SENSORS_SBTSI
>  	tristate "Emulated SB-TSI temperature sensor"
> -	depends on I2C
> +	select AMD_SBTSI
>  	help
>  	  If you say yes here you get support for emulated temperature
>  	  sensors on AMD SoCs with SB-TSI interface connected to a BMC device.

> diff --git a/drivers/misc/amd-sbi/Kconfig b/drivers/misc/amd-sbi/Kconfig
> index 30e7fad7356c..512251690e0e 100644
> --- a/drivers/misc/amd-sbi/Kconfig
> +++ b/drivers/misc/amd-sbi/Kconfig
> @@ -20,3 +20,16 @@ config AMD_SBRMI_HWMON
>  	  This provides support for RMI device hardware monitoring. If enabled,
>  	  a hardware monitoring device will be created for each socket in
>  	  the system.
> +
> +config AMD_SBTSI
> +	tristate "AMD side band TSI support"
> +	depends on I2C
> +	depends on ARM || ARM64 || COMPILE_TEST
> +	select AUXILIARY_BUS
> +	help
> +	  Enables support for the AMD SB-TSI (Side Band Temperature Sensor
> +	  Interface) driver, which provides access to emulated CPU temperature
> +	  sensors on AMD SoCs via an I2C connected BMC device.
> +
> +	  This driver can also be built as a module. If so, the module will
> +	  be called sbtsi.

Your kconfig changes introduce an unmet dependency bug. When I enable
SENSORS_SBTSI without enabling COMPILE_TEST on x86, I get this:

WARNING: unmet direct dependencies detected for AMD_SBTSI
  Depends on [n]: I2C [=y] && (ARM || ARM64 || COMPILE_TEST [=n])
  Selected by [y]:
  - SENSORS_SBTSI [=y] && HWMON [=y]

- Julian Braha